Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gosec to SAST analysis #755

Merged
merged 8 commits into from
May 24, 2024
Merged

Add gosec to SAST analysis #755

merged 8 commits into from
May 24, 2024

Conversation

WaqarAhmedVC
Copy link
Contributor

Description

Add gosec to perform Static Application Security Testing (SAST) Analysis.

Fixes # (issue)

  • Non existent SAST tool in the build pipeline

Type of change

Please delete options that are not relevant.

  • New feature - Adding SAST tool in workflow (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Adding a new tool in the workflow file. Tested to perform the required security checks without breaking

Test Configuration:

  • NA

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.88%. Comparing base (b9047c0) to head (36e44b6).

Files Patch % Lines
cache/rnd_cache.go 50.00% 1 Missing ⚠️
cmd/thor/utils.go 0.00% 1 Missing ⚠️
comm/peer.go 0.00% 1 Missing ⚠️
p2psrv/rpc/rpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   61.88%   61.88%           
=======================================
  Files         202      202           
  Lines       18696    18696           
=======================================
  Hits        11570    11570           
  Misses       6015     6015           
  Partials     1111     1111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darrenvechain
Copy link
Member

darrenvechain commented May 24, 2024

@WaqarAhmedVC we can add gosec to the linters in our lint config:

https://github.com/vechain/thor/blob/master/.golangci.yml#L13

image

@WaqarAhmedVC
Copy link
Contributor Author

@darrenvechain Thanks for pointing out. I was searching for this info but couldn't find it.

@otherview otherview marked this pull request as ready for review May 24, 2024 10:19
@otherview otherview requested a review from a team as a code owner May 24, 2024 10:19
@otherview otherview requested a review from libotony May 24, 2024 13:21
@vechain vechain deleted a comment from otherview May 24, 2024
@otherview otherview merged commit 3962325 into master May 24, 2024
14 checks passed
@otherview otherview deleted the add-gosec branch May 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants