Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm publishing compatability #1135

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: npm publishing compatability #1135

merged 1 commit into from
Aug 6, 2024

Conversation

darrenvechain
Copy link
Member

Description

Fix NPM packages. Makes them compatible with CJS + ESM

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner August 6, 2024 14:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 98%
 98.66% (3482/3529) 95.61% (916/958) 99.42% (689/693)
Title Tests Skipped Failures Errors Time
core 478 0 💤 0 ❌ 0 🔥 1m 5s ⏱️
network 671 0 💤 0 ❌ 0 🔥 3m 36s ⏱️
errors 6 0 💤 0 ❌ 0 🔥 5.435s ⏱️

@fabiorigam fabiorigam merged commit 955dc24 into main Aug 6, 2024
12 checks passed
@fabiorigam fabiorigam deleted the fix-npm-publishing branch August 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiorigam fabiorigam fabiorigam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenvechain @fabiorigam