Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1114 class revision #1175

Merged
merged 3 commits into from
Aug 18, 2024
Merged

1114 class revision #1175

merged 3 commits into from
Aug 18, 2024

Conversation

lucanicoladebiasi
Copy link
Contributor

Description

The VeChain Data Model packages/core/src/vcdm/Revision.ts class replaces the /utils/quantity functional constant.

The VeChain Data Model packages/core/src/vcdm/Quantity.ts class replaces the /utils/quantity functional constant.

Documentation and examples provided.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test yarn:examples
  • test yarn:solo
  • test yarn:unit

Test Configuration:

  • Node.js Version: v20.14.0
  • Yarn Version: 1.22.22

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

Copy link

github-actions bot commented Aug 16, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99.27% (3578/3604) 97.59% (933/956) 99.15% (704/710)
Title Tests Skipped Failures Errors Time
core 527 0 💤 0 ❌ 0 🔥 1m 6s ⏱️
network 684 0 💤 0 ❌ 0 🔥 3m 38s ⏱️
errors 40 0 💤 0 ❌ 0 🔥 12.504s ⏱️

@lucanicoladebiasi lucanicoladebiasi merged commit dbf6996 into main Aug 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class Revision
2 participants