Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: class Account #1178

Merged
merged 36 commits into from
Aug 21, 2024
Merged

feat: class Account #1178

merged 36 commits into from
Aug 21, 2024

Conversation

freemanzMrojo
Copy link
Member

Description

Classes Account and ExternallyOwnedAccount as per the VeChain Data Model. Closes #1104 .

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have added tests for every path except for the account type check (to be done once we create the Contract class).

  • ExternallyOwnedAccount.unit.test.ts

Test Configuration:

  • Node.js Version: 20.12.1
  • Yarn Version: 1.22.19

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@freemanzMrojo freemanzMrojo requested a review from a team as a code owner August 20, 2024 14:13
@freemanzMrojo freemanzMrojo added this to the RC milestone Aug 20, 2024
@freemanzMrojo freemanzMrojo self-assigned this Aug 20, 2024
Copy link

github-actions bot commented Aug 20, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99.12% (3640/3672) 97.14% (953/981) 99.18% (728/734)
Title Tests Skipped Failures Errors Time
core 542 0 💤 0 ❌ 0 🔥 1m 9s ⏱️
network 684 0 💤 0 ❌ 0 🔥 3m 47s ⏱️
errors 40 0 💤 0 ❌ 0 🔥 13.537s ⏱️

Copy link
Contributor

@rodolfopietro97 rodolfopietro97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @freemanzMrojo 💪
Only 1 little feed related to TODO

@freemanzMrojo freemanzMrojo merged commit 755ce19 into main Aug 21, 2024
12 checks passed
@freemanzMrojo freemanzMrojo deleted the feat/class-account branch August 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class Account
2 participants