Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1312 2 phase build for the rpc proxy dockerfile #1313

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

daithihearn
Copy link
Member

@daithihearn daithihearn commented Sep 18, 2024

Description

There was no build phase on the Dockerfile so I added one. The final image should only contain the files that are needed to run the application and not all of the source files and other unnecessary files.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

This is a non functional change. Ensure the dockerfile builds and runs.

Test Configuration:

  • Node.js Version:
  • Yarn Version:

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@daithihearn daithihearn requested a review from a team as a code owner September 18, 2024 21:20
@daithihearn daithihearn linked an issue Sep 18, 2024 that may be closed by this pull request
3 tasks
Copy link

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 98%
98.82% (4207/4257) 97.79% (1332/1362) 98.83% (845/855)
Title Tests Skipped Failures Errors Time
core 779 0 💤 0 ❌ 0 🔥 1m 52s ⏱️
network 687 0 💤 0 ❌ 0 🔥 4m 43s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 17.885s ⏱️

@fabiorigam fabiorigam merged commit 3a55745 into main Sep 19, 2024
12 checks passed
@fabiorigam fabiorigam deleted the 1312-2-phase-build-for-the-rpc-proxy-dockerfile branch September 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 phase build for the RPC Proxy Dockerfile
2 participants