Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tsconfig should reflect either composite or declaration when declarationMap is true #1351

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

freemanzMrojo
Copy link
Member

Description

The title is self-explanatory.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test suite of this repo.

Test Configuration:

  • Node.js Version: 20.17.0
  • Yarn Version: 1.22.19

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@freemanzMrojo freemanzMrojo requested a review from a team as a code owner September 25, 2024 16:14
Copy link

github-actions bot commented Sep 25, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 97%
97.8% (4184/4278) 95.83% (1359/1418) 97.05% (856/882)
Title Tests Skipped Failures Errors Time
core 764 0 💤 0 ❌ 0 🔥 1m 54s ⏱️
network 692 0 💤 0 ❌ 0 🔥 4m 48s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 17.876s ⏱️

@freemanzMrojo freemanzMrojo merged commit 1955abc into main Sep 26, 2024
12 checks passed
@freemanzMrojo freemanzMrojo deleted the fix/tsc-declaration-true branch September 26, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants