Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

806 ethers compatible signer #831

Merged
merged 19 commits into from
May 3, 2024
Merged

Conversation

rodolfopietro97
Copy link
Contributor

Description

Finish missing ethers signer methods implementation

@rodolfopietro97 rodolfopietro97 requested a review from a team as a code owner April 29, 2024 14:03
@rodolfopietro97 rodolfopietro97 linked an issue Apr 29, 2024 that may be closed by this pull request
2 tasks
@rodolfopietro97 rodolfopietro97 marked this pull request as draft April 29, 2024 14:03
Copy link

github-actions bot commented Apr 29, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 100%
100% (3129/3129) 100% (693/693) 100% (652/652)
Title Tests Skipped Failures Errors Time
core 463 0 💤 0 ❌ 0 🔥 1m 4s ⏱️
network 601 0 💤 0 ❌ 0 🔥 3m 15s ⏱️
errors 48 0 💤 0 ❌ 0 🔥 14.648s ⏱️

@rodolfopietro97 rodolfopietro97 marked this pull request as ready for review May 2, 2024 09:41
Copy link
Contributor

@Valazan Valazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There're just some questions on my side

@rodolfopietro97 rodolfopietro97 merged commit a2bcd64 into main May 3, 2024
11 checks passed
@rodolfopietro97 rodolfopietro97 deleted the 806-ethers-compatible-signer branch May 3, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethers compatible signer
3 participants