Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing packages #860

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: add missing packages #860

merged 1 commit into from
May 13, 2024

Conversation

fabiorigam
Copy link
Member

No description provided.

@fabiorigam fabiorigam linked an issue May 13, 2024 that may be closed by this pull request
Copy link

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 100%
100% (3118/3118) 100% (690/690) 100% (650/650)
Title Tests Skipped Failures Errors Time
core 463 0 💤 0 ❌ 0 🔥 1m 5s ⏱️
network 606 0 💤 0 ❌ 0 🔥 3m 42s ⏱️
errors 48 0 💤 0 ❌ 0 🔥 15.106s ⏱️

@fabiorigam fabiorigam marked this pull request as ready for review May 13, 2024 08:02
@fabiorigam fabiorigam requested a review from a team as a code owner May 13, 2024 08:02
@@ -36,10 +36,13 @@
},
"dependencies": {
"@ethereumjs/rlp": "^5.0.2",
"@scure/bip32": "^1.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiorigam Are this package security compliant @lucanicoladebiasi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!

@fabiorigam fabiorigam merged commit 3e7e74c into main May 13, 2024
11 checks passed
@fabiorigam fabiorigam deleted the 859-hdnode-is-broken branch May 13, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HDNode is broken
2 participants