Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 666 pure and secure packages/core/src/clause.ts #886

Merged
merged 2 commits into from
May 20, 2024

Conversation

lucanicoladebiasi
Copy link
Contributor

@lucanicoladebiasi lucanicoladebiasi commented May 20, 2024

Description

This tiny PR makes the code at packages/core/src/clause/clause.ts to depends on internal addressUtils.isAddress function instead of ethers.isAddress.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • yarn test:solo
  • yarn test:unit

Test Configuration:

  • Node.js Version: v21.6.2
  • Yarn Version: 1.22.22

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@lucanicoladebiasi lucanicoladebiasi self-assigned this May 20, 2024
@lucanicoladebiasi lucanicoladebiasi requested a review from a team as a code owner May 20, 2024 13:41
@lucanicoladebiasi lucanicoladebiasi changed the title refactor: 666 pure and secure packages/core/src/clause.ts refactor: 666 pure and secure packages/core/src/clause.ts May 20, 2024
Copy link

github-actions bot commented May 20, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99.81% (3267/3273) 99.33% (748/753) 99.7% (675/677)
Title Tests Skipped Failures Errors Time
core 473 0 💤 0 ❌ 0 🔥 1m 10s ⏱️
network 641 0 💤 0 ❌ 0 🔥 4m 7s ⏱️
errors 48 0 💤 0 ❌ 0 🔥 14.033s ⏱️

@lucanicoladebiasi lucanicoladebiasi merged commit 6d58567 into main May 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants