Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Vechain abstract signer #903

Merged
merged 3 commits into from
May 22, 2024
Merged

feat: Vechain abstract signer #903

merged 3 commits into from
May 22, 2024

Conversation

rodolfopietro97
Copy link
Contributor

@rodolfopietro97 rodolfopietro97 commented May 22, 2024 •
edited
Loading

Checklist:

  • Rename VechainBaseSigner to VechainPrivateKeySigner
  • Create VechainAbstractSigner

@rodolfopietro97 rodolfopietro97 requested a review from a team as a code owner May 22, 2024 09:55
@rodolfopietro97 rodolfopietro97 linked an issue May 22, 2024 that may be closed by this pull request
Implement AbstractSigner #895
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
 99.82% (3366/3372) 99.23% (775/781) 99.71% (692/694)
Title Tests Skipped Failures Errors Time
core 478 0 💤 0 ❌ 0 🔥 1m 10s ⏱️
network 647 0 💤 0 ❌ 0 🔥 3m 39s ⏱️
errors 48 0 💤 0 ❌ 0 🔥 11.151s ⏱️

@rodolfopietro97 rodolfopietro97 merged commit f697f68 into main May 22, 2024
11 checks passed
@rodolfopietro97 rodolfopietro97 deleted the 895-implement-abstractsigner branch May 22, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiorigam fabiorigam fabiorigam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AbstractSigner
2 participants
@rodolfopietro97 @fabiorigam