Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 802 composable bloom filters #917

Merged
merged 3 commits into from
May 28, 2024

Conversation

lucanicoladebiasi
Copy link
Contributor

Description

Bloom filters are composable if they share m and k parameters.

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • yarn test:unit
  • yarn test:solo

Test Configuration:

  • Node.js Version: v22.2.0
  • Yarn Version: 1.22.22

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@lucanicoladebiasi lucanicoladebiasi self-assigned this May 27, 2024
@lucanicoladebiasi lucanicoladebiasi requested a review from a team as a code owner May 27, 2024 19:20
@lucanicoladebiasi lucanicoladebiasi linked an issue May 27, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 27, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 100%
100% (3378/3378) 99.87% (782/783) 100% (697/697)
Title Tests Skipped Failures Errors Time
core 485 0 💤 0 ❌ 0 🔥 1m 6s ⏱️
network 656 0 💤 0 ❌ 0 🔥 3m 39s ⏱️
errors 48 0 💤 0 ❌ 0 🔥 10.518s ⏱️

@fabiorigam fabiorigam merged commit 15887b7 into main May 28, 2024
11 checks passed
@fabiorigam fabiorigam deleted the 802-extend-the-bloom-filter-to-support-operands branch May 28, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the Bloom Filter to support operands.
2 participants