Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dappkit fixes #918

Merged
merged 9 commits into from
May 29, 2024
Merged

feat: dappkit fixes #918

merged 9 commits into from
May 29, 2024

Conversation

rodolfopietro97
Copy link
Contributor

@rodolfopietro97 rodolfopietro97 commented May 28, 2024

Description

Fixes needed to integrate Dappkit

Checklist

  • Change signer call method return type to string
  • Abstract provider internal wallet AND getDelegatorSync

@rodolfopietro97 rodolfopietro97 requested a review from a team as a code owner May 28, 2024 09:41
@rodolfopietro97 rodolfopietro97 marked this pull request as draft May 28, 2024 09:41
Copy link

github-actions bot commented May 28, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 100%
100% (3386/3386) 100% (783/783) 100% (701/701)
Title Tests Skipped Failures Errors Time
core 485 0 💤 0 ❌ 0 🔥 1m 5s ⏱️
network 657 0 💤 0 ❌ 0 🔥 3m 35s ⏱️
errors 48 0 💤 0 ❌ 0 🔥 11.116s ⏱️

@rodolfopietro97 rodolfopietro97 marked this pull request as ready for review May 29, 2024 06:51
@rodolfopietro97 rodolfopietro97 merged commit 7f5d4c8 into main May 29, 2024
12 checks passed
@rodolfopietro97 rodolfopietro97 deleted the dappkit-fixes-1 branch May 29, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants