Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove message audio element (for another pr) #25477

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Remove message audio element (for another pr) #25477

merged 9 commits into from
Jul 4, 2024

Conversation

SuperKenVery
Copy link
Contributor

@SuperKenVery SuperKenVery commented May 30, 2023 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Works with matrix-org/matrix-react-sdk#10995

Signed-off-by: 许煜恒 [email protected]

Type: defect

Here's what your changelog entry will look like:

🐛 Bug Fixes

@SuperKenVery SuperKenVery requested a review from a team as a code owner May 30, 2023 10:54
@SuperKenVery SuperKenVery mentioned this pull request May 30, 2023
Merged
3 tasks
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Defect labels May 30, 2023
@SuperKenVery
Copy link
Contributor Author

Cannot pass test because

matrix-org/matrix-react-sdk#10995 (comment)

germain-gg
germain-gg suggested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like the issue you're experiencing with Element appearing in media control will continue until you delete all the audio element and make things play through the WebAudio API.

@SuperKenVery
Copy link
Contributor Author

Hmm... seems true. Currently it works because sound other than message ringtone hasn't been played...

Will try to do that more thoroughly :D

SuperKenVery and others added 7 commits June 26, 2023 23:10
@SuperKenVery
Merge branch 'develop' of github.com:vector-im/element-web into super…
85dbaaa 
…kenvery/webaudioapi
@SuperKenVery
Remove (almost) all <audio> tags
b98289c 
Not sure what `remoteAudio` does, seems only used in tests,
so I left it there.
@t3chguy
Merge branch 'develop' into superkenvery/webaudioapi
6821a35
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
d60768d 
…to fork/SuperKenVery/superkenvery/webaudioapi
@t3chguy
Iterate
e80ab73 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
d1f0cbe 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
746c20b 
…to fork/SuperKenVery/superkenvery/webaudioapi
@t3chguy t3chguy added T-Task Tasks for the team like planning and removed T-Defect labels Jul 4, 2024
@t3chguy t3chguy enabled auto-merge July 4, 2024 18:27
@t3chguy t3chguy added this pull request to the merge queue Jul 4, 2024
Merged via the queue into element-hq:develop with commit b4d3430 Jul 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg requested changes

@t3chguy t3chguy t3chguy approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperKenVery @germain-gg @t3chguy