Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-line reactions block message content #753

Closed
Tracked by #342
jonnyandrew opened this issue Jul 3, 2023 · 0 comments · Fixed by #785
Closed
Tracked by #342

Multi-line reactions block message content #753

jonnyandrew opened this issue Jul 3, 2023 · 0 comments · Fixed by #785
Assignees
@jonnyandrew
Labels
A-Reactions O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@jonnyandrew
Copy link
Contributor

jonnyandrew commented Jul 3, 2023 •
edited
Loading

Steps to reproduce

  1. Where are you starting? What can you see?
  • Open a room containing messages
  1. What do you click?
  • Send or receive many reactions to a message
  • Ensure the emoji reactions wrap onto the next line

Outcome

What did you expect?

  • Emojis appear below the message, not blocking it

What happened instead?

  • Emojis block the message

image

Your phone model

Emulator

Operating system version

Android 13

Application version and app store

develop / 3a7ee9b

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@jonnyandrew jonnyandrew added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Reactions labels Jul 3, 2023
@jonnyandrew jonnyandrew changed the title Reactions block message Multi-line reactions block message content Jul 3, 2023
@jonnyandrew jonnyandrew mentioned this issue Jul 3, 2023
Closed
@jonnyandrew jonnyandrew self-assigned this Jul 5, 2023
@jonnyandrew jonnyandrew mentioned this issue Jul 5, 2023
Merged
jonnyandrew added a commit that referenced this issue Jul 6, 2023
@jonnyandrew
Fix multi-line reactions blocking message content
a00c523 
Fixes #753
jonnyandrew added a commit that referenced this issue Jul 6, 2023
@jonnyandrew
Fix multi-line reactions blocking message content (#785)
c87e14a 
Fixes #753

---------

Co-authored-by: ElementBot <[email protected]>
MatMaul pushed a commit that referenced this issue Jul 6, 2023
@jonnyandrew
Fix multi-line reactions blocking message content (#785)
5b7c42a 
Fixes #753

---------

Co-authored-by: ElementBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonnyandrew jonnyandrew

Labels
A-Reactions O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix multi-line reactions blocking message content element-hq/element-x-android
1 participant
@jonnyandrew