Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room screen: Header UI #35

Closed
manuroe opened this issue May 4, 2022 · 0 comments · Fixed by #86
Closed

Room screen: Header UI #35

manuroe opened this issue May 4, 2022 · 0 comments · Fixed by #86
Assignees
@ismailgulek
Labels
A-Timeline X-Needs-Design Z-BBQ-Alpha Required for ElementX - BBQ - Alpha

Comments

@manuroe
Copy link
Member

manuroe commented May 4, 2022 •
edited by VolkerJunginger
Loading

We need an header to use in the room screen.

We could simply reused the one in this [design](https://www.figma.com/file/zVtAKK0hzKu5JkpbzlE1pG/Message-Bubbles?node-id=1%3A29\] with no call buttons
@manuroe manuroe added Z-BBQ-Alpha Required for ElementX - BBQ - Alpha X-Needs-Design A-Timeline labels May 4, 2022
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Create ElementNavigationController subclass
ade3870
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Add encryption icons
70787ba
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Add avatar and encryption badge image to the room screen view model
5db7484
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Create RoomHeaderView class
7c358ed
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Replace room title with a RoomHeaderView instance in the toolbar
2206502
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Add changelog
225231e
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Introduce UITestScreenIdentifier and refactor ui tests
646beb3
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Fix old tests
9042587
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 add some tests for room screen
648debd
@ismailgulek ismailgulek mentioned this issue Jun 21, 2022
Merged
@ismailgulek ismailgulek self-assigned this Jun 21, 2022
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Use svgs instead of pngs
52bbe3e
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
#35 Fix PR remarks
45ae7e3
ismailgulek added a commit that referenced this issue Jun 21, 2022
@ismailgulek
Room screen header (#86)
7dcd494 
* #35 Create `ElementNavigationController` subclass

* #35 Add encryption icons

* #35 Add avatar and encryption badge image to the room screen view model

* #35 Create `RoomHeaderView` class

* #35 Replace room title with a RoomHeaderView instance in the toolbar

* #35 Add changelog

* #35 Introduce `UITestScreenIdentifier` and refactor ui tests

* #35 Fix old tests

* #35 add some tests for room screen

* #35 Use svgs instead of pngs

* #35 Fix PR remarks
This was referenced Jun 27, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Jul 4, 2022
Merged
@github-actions github-actions bot mentioned this issue Jul 6, 2022
Merged
This was referenced Jul 18, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
A-Timeline X-Needs-Design Z-BBQ-Alpha Required for ElementX - BBQ - Alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Room screen header element-hq/element-x-ios
2 participants
@ismailgulek @manuroe