-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic AuthenticationService and missing UI tests. #126
Conversation
236ba6c
to
0bfd858
Compare
Generated by 🚫 Danger Swift against e8852bc |
Changes in 126 (2022-07-05)✨ Features
🙌 Improvements
🐛 Bugfixes
🧱 Build
Others
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/e4LtWn |
Codecov Report
@@ Coverage Diff @@
## develop #126 +/- ##
===========================================
+ Coverage 30.56% 35.57% +5.01%
===========================================
Files 161 166 +5
Lines 11429 11530 +101
Branches 5576 5636 +60
===========================================
+ Hits 3493 4102 +609
+ Misses 7846 7337 -509
- Partials 90 91 +1
Continue to review full report at Codecov.
|
ElementX/Sources/Screens/Authentication/LoginScreen/LoginCoordinator.swift
Outdated
Show resolved
Hide resolved
a816988
to
5173a29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. It's perfect to see our coverage is climbing 👍
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Moves authentication into a basic AuthenticationService, adds a mock of this service and tests for both server selection and the whole auth flow.