Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danger doesn't detect new changelog files. #74

Closed
pixlwave opened this issue Jun 8, 2022 · 0 comments · Fixed by #75
Closed

Danger doesn't detect new changelog files. #74

pixlwave opened this issue Jun 8, 2022 · 0 comments · Fixed by #75
Labels
A-DevX Anything that can improve the DevX

Comments

@pixlwave
Copy link
Member

pixlwave commented Jun 8, 2022

If you create a PR with a new changelog file, Danger comments that you should add one. It looks like it is only checking modified files rather than new files, but switching this line to use editedFiles didn't seem to work when I tested it on a PR.
@pixlwave pixlwave added the A-DevX Anything that can improve the DevX label Jun 8, 2022
@pixlwave pixlwave mentioned this issue Jun 8, 2022
Merged
This was referenced Jun 27, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 4, 2022
Merged
Merged
This was referenced Jul 18, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-DevX Anything that can improve the DevX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Danger's changelog detection. element-hq/element-x-ios
1 participant
@pixlwave