-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UI for setting HTTP proxy to desktop app #772
Comments
Apparently, you can set the proxy by using a |
@uhoreg yeah but you asked for a UI :P |
@t3chguy yup, just documenting here since people who are asking about proxying will probably find this issue. This way, they can use the command-line switch until a UI is done. ;) |
I tested this for a SOCKS5 proxy (Tor) and it does not work. It seems that electron does not support --proxy-server as a command line parameter. Riot is simply ignoring the parameter and connects the normal way. This is pretty bad because you assume that everything works over the proxy. |
@devdan what OS? If its through Squirrel (Windows and possibly Mac) the argument may get consumed before it makes it to electron |
Tested on Windows with the installer provided by riot.im. I don't know if it uses Squirrel or not. |
@devdan yep that uses Squirrel.Windows as the updating mechanism, depending on which executable you are passing the argument to it may be consumed. Try passing it to the executable |
This works. Thanks a lot! Still, it would be very nice to have UI settings for this. |
@devdan definitely going to happen eventually, I'm looking at making giving the app a more userful top bar to replace the standard system window chroming which could have proxy settings as an option, currently hard to shove proxy settings somewhere as you cannot reach user settings pre-login or when on the login spinner |
Proxy settings in UI would be nice yes! |
Any updates on this? For those of us in less fortunate political environments, Tor support will quickly become pretty crucial. |
+1 |
note to self, auth proxies in electron are meh: electron/electron#3250 |
For quick&dirty you can also make a riot.cmd wherever you want and add there the following line |
Can't connect and send messages in China. Need network proxy function, urgent! |
As documented in comments before, proxy function is already possible just has no ui |
We just tried the workaround from 22 Oct 2018 on a Windows 10 PC but it doesn't work. Does it only work with a socks5 proxy? We have a squid proxy at http://IP:3128/ but no matter how we use the parameter We tried (with and without surrounding "" for the proxy parameter):
|
Re-read https://github.com/vector-im/riot-web/issues/3320#issuecomment-318668688 . |
This comment was marked as outdated.
This comment was marked as outdated.
The proxy engine in electron/chromium supports socks proxies so it's not at all incorrect. And any ui for proxy will work with both |
request some priority be given this 2+ year old issue. To run with command switch is a "work-around" that not many will learn of unless they search issues here, attempt to sort the command needed then verify it is working as expected.
the above two comments speak of the true need for a solid proxy support (HTTP, and Socks4a and Socks5) and adding the settings to UI is the way to do it correctly for the masses. |
Just in case anyone else is confused by the example |
+1 needed |
any progress on this ? |
It is not critical as it is possible already to do over the command line, it just doesn't have a shiny UI. No privacy issues here, just user-friendliness ones. |
I'm on debian9 using the Nightly version and I'm not sure if riot is using tor, if I put a not valid proxy it seems to connect to internet, how can I be sure? |
|
Any updates getting this done? |
+1 |
Yes, the electron proxy argument isn't honored by the client |
i need tor too ! |
Copy & paste from the duplicated issue as some supplement information: What would you like to do?Change the proxy manually instead of using the system default proxy. Why would you like to do it?Accessing the global internet in some countries (e.g. China) could be complex. Sometimes we may want to proxy some software, while not touching the system proxy settings. A good example is Telegram, which allows the user to specify a list of the socks5 proxy, and can switch between them on the fly. How would you like to achieve it?Give user three options in the setting page:
|
Just FYI guys, However, as already noted elsewhere, the auto-update mechanism will still bypass the proxy. To be really safe you have to use a more secure operating system (Whonix / Tails / Qubes) or at least use an iptables-based solution instead of the command line switch. I wouldn't trust a |
On macOS do:
|
|
It has limitations, though, see my post above. |
This comment was marked as spam.
This comment was marked as spam.
How is the progress about the implementation to pass the proxy via the ui instead of terminal command? |
This comment was marked as off-topic.
This comment was marked as off-topic.
@HumanPopcycle this repo is called element-desktop for a reason... It has nothing to do with the Android app. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@HumanPopcycle https://github.com/vector-im/element-android is a native Kotlin project. |
Bumping this as lack of native SOCKS5 support is a reason for people to stick to Telegram over Element. |
@tidux contributions welcome. |
Any news? |
No description provided.
The text was updated successfully, but these errors were encountered: