Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File context_key cannot be disabled #151

Closed
binarylogic opened this issue Mar 20, 2019 · 1 comment
Closed

File context_key cannot be disabled #151

binarylogic opened this issue Mar 20, 2019 · 1 comment
Labels
source: file Anything `file` source related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@binarylogic
Copy link
Contributor

The file source context_key option cannot be disabled. I'm curious how we should handle this.

A couple of options:

  1. Don't default context_key and require it to be explicitly specified.
  2. Since Toml does not support nil values we could allow a value of "none".
@binarylogic binarylogic added source: file Anything `file` source related type: enhancement A value-adding code change that enhances its existing functionality. labels Mar 20, 2019
@binarylogic
Copy link
Contributor Author

Closing this for now since we've decided not to do it. You can use the remove_fields transform to drop the key. If someone can make the case for not including this we can reopen it.

aholmberg pushed a commit to aholmberg/vector that referenced this issue Feb 14, 2024
@darinspivey
Merge pull request vectordotdev#151 from answerbook/darinspivey/LOG-1…
c27ab24 
…5589

fix(transforms): `mezmo_reduce` needs to handle special-case fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
source: file Anything `file` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binarylogic