chore(networking): Upgrade service and retries in sink util
#2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Franco <[email protected]>
Signed-off-by: Lucio Franco <[email protected]>
Signed-off-by: Lucio Franco <[email protected]>
Signed-off-by: Lucio Franco <[email protected]>
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
| @@ -75,7 +75,7 @@ rusoto_sts = { version = "0.41.0", optional = true } | |||
|
|
|||
| # Tower | |||
| tower = "0.1.1" | |||
| tower03 = { package = "tower", version = "0.3" } | |||
| tower03 = { package = "tower", version = "0.3", git = "https://github.com/tower-rs/tower", features = ["limit", "retry", "timeout", "util"] } | |||
There was a problem hiding this comment.
current release of 0.3 has some bounds issues that are fixed on master, we plan to release 0.4 soon with proper docs etc. So this is a place holder until then. The master version contains the layers we need as well that I up streamed.
There was a problem hiding this comment.
lukesteensen
approved these changes
Apr 20, 2020
…o lucio/update-tower-2
Signed-off-by: Lucio Franco <[email protected]>
Signed-off-by: Lucio Franco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my second attempt at upgrading tower services internally. We now no longer vendor
Mapsince that is now included in tower asmap_request. We also no longer need to vendor timeout.This is broken up into three commits 1) copy 2) upgrade 3) compat layer and re-enabling batch. I also had to disable some tests because of a fun rustc bug on stable that is fixed on nightly.