Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump regex from 1.4.3 to 1.4.5 #6762

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 15, 2021

Bumps regex from 1.4.3 to 1.4.5.

Changelog

Sourced from regex's changelog.

1.4.5 (2021-03-14)

This is a small patch release that fixes a regression in the size of a Regex in the 1.4.4 release. Prior to 1.4.4, a Regex was 552 bytes. In the 1.4.4 release, it was 856 bytes due to internal changes. In this release, a Regex is now 16 bytes. In general, the size of a Regex was never something that was on my radar, but this increased size in the 1.4.4 release seems to have crossed a threshold and resulted in stack overflows in some programs.

  • [BUG #750](rust-lang/regex#750): Fixes stack overflows seemingly caused by a large Regex size by decreasing its size.

1.4.4 (2021-03-11)

This is a small patch release that contains some bug fixes. Notably, it also drops the thread_local (and lazy_static, via transitivity) dependencies.

Bug fixes:

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team and juchiast and removed request for a team March 15, 2021 14:30
@dependabot dependabot bot added the domain: deps Anything related to Vector's dependencies label Mar 15, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 15, 2021

Dependabot tried to add @fanatid as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/timberio/vector/pulls/6762/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the timberio/vector repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

@dependabot dependabot bot force-pushed the dependabot/cargo/regex-1.4.5 branch from e12d694 to 881a78b Compare March 15, 2021 16:19
@jszwedko
Copy link
Member

I'm getting the feeling that the benches still have some undesired noise. I reran them on a benchmark runner and got, for just regressions:

remap-functions/parse_apache_log/error                                                               7.7162 us  +5.7334%     129.60 Kelem/s  -5.4225%           0.00  regressed
remap-functions/to_string/string                                                                     41.916 ns  +7.7197%     23.858 Melem/s  -7.1665%           0.00  regressed
create and insert single-level                                                                       705.02 ns  +8.8742%     unknown         unknown            0.00  regressed
create and insert nested-keys                                                                        1.1224 us  +5.9778%     unknown         unknown            0.00  regressed
metrics_snapshot/cardinality/100                                                                     34.904 us  +2.3329%     unknown         unknown            0.00  regressed
metrics_snapshot/cardinality/10000                                                                   6.2536 ms  +22.820%     unknown         unknown            0.00  regressed
language/parse_json/native                                                                           81.508 ms  +6.4223%     122.69 Kelem/s  -6.0347%           0.00  regressed
language/parse_syslog/native                                                                         128.19 ms  +5.4430%     78.008 Kelem/s  -5.1620%           0.00  regressed
metrics_off/topology/tcp_socket/08_writers                                                           283.43 ms  +10.515%     26.918 MiB/s    -9.5149%           0.00  regressed
metrics_off/topology/tcp_socket/16_writers                                                           605.85 ms  +11.454%     25.186 MiB/s    -10.277%           0.00  regressed

@jszwedko jszwedko merged commit d28c888 into master Mar 16, 2021
@jszwedko jszwedko deleted the dependabot/cargo/regex-1.4.5 branch March 16, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: deps Anything related to Vector's dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant