Skip to content

Commit

Permalink
style: Remove outdated comments about the use of the former _Paramete…
Browse files Browse the repository at this point in the history
…r protocol (#3448)
  • Loading branch information
binste authored Jun 27, 2024
1 parent 485eae5 commit c9106f0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
3 changes: 0 additions & 3 deletions altair/vegalite/v5/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,6 @@ def _get_channels_mapping() -> dict[type[SchemaBase], str]:
class Parameter(_expr_core.OperatorMixin):
"""A Parameter object"""

# NOTE: If you change this class, make sure that the protocol in
# altair/vegalite/v5/schema/core.py is updated accordingly if needed.

_counter: int = 0

@classmethod
Expand Down
8 changes: 3 additions & 5 deletions tools/schemapi/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,9 @@ def get_python_type_representation(
class_names = ["SchemaBase"]
if self.title == "ExprRef":
# In these cases, a value parameter is also always accepted.
# We use the _Parameter to indicate this although this
# protocol would also pass for selection parameters but
# due to how the Parameter class is defined, it would be quite
# complex to further differentiate between a value and
# a selection parameter based on the type system (one could
# It would be quite complex to further differentiate
# between a value and a selection parameter based on
# the type system (one could
# try to check for the type of the Parameter.param attribute
# but then we would need to write some overload signatures for
# api.param).
Expand Down

0 comments on commit c9106f0

Please sign in to comment.