Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/main' into vega-expr-gen
Browse files Browse the repository at this point in the history
  • Loading branch information
dangotbanned committed Oct 2, 2024
2 parents d95a573 + 17968ea commit c91b71c
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tests/vegalite/v5/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ def test_when_labels_position_based_on_condition() -> None:
expr=alt.expr.if_(param_width_lt_200, "red", "black")
)
when = (
alt.when(param_width_lt_200)
alt.when(param_width_lt_200.expr)
.then(alt.value("red"))
.otherwise(alt.value("black"))
)
Expand All @@ -564,7 +564,11 @@ def test_when_labels_position_based_on_condition() -> None:
test = cond["test"]
assert not isinstance(test, alt.PredicateComposition)
param_color_py_when = alt.param(expr=alt.expr.if_(test, cond["value"], otherwise))
assert param_color_py_expr.expr == param_color_py_when.expr
lhs_param = param_color_py_expr.param
rhs_param = param_color_py_when.param
assert isinstance(lhs_param, alt.VariableParameter)
assert isinstance(rhs_param, alt.VariableParameter)
assert repr(lhs_param.expr) == repr(rhs_param.expr)

chart = (
alt.Chart(df)
Expand Down

0 comments on commit c91b71c

Please sign in to comment.