Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: properly propagate context in multiply-specified encodings #1587

Merged
merged 2 commits into from
Jul 1, 2019
Merged

BUG: properly propagate context in multiply-specified encodings #1587

merged 2 commits into from
Jul 1, 2019

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Jul 1, 2019

Fixes #1586

@jakevdp jakevdp mentioned this pull request Jul 1, 2019
Closed
@jakevdp
Copy link
Collaborator Author

jakevdp commented Jul 1, 2019

Still needs a unit test.

@jakevdp
Copy link
Collaborator Author

jakevdp commented Jul 1, 2019

Also confirmed that the new test catches the regression if the change to channels.py is reverted.

@jakevdp jakevdp merged commit 2e515e4 into vega:master Jul 1, 2019
@jakevdp jakevdp deleted the tooltip-data-context branch July 1, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alt.Tooltip not behaving the same way as not specifying the object
1 participant
@jakevdp