Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow Paths in save() #2355

Merged
merged 2 commits into from
Dec 1, 2020
Merged

allow Paths in save() #2355

merged 2 commits into from
Dec 1, 2020

Conversation

RoyalTS
Copy link
Contributor

@RoyalTS RoyalTS commented Nov 30, 2020

Fixes #2354

@RoyalTS RoyalTS mentioned this pull request Nov 30, 2020
Closed
@jakevdp
Copy link
Collaborator

jakevdp commented Nov 30, 2020

This is great, thanks! It would be useful to add a test as well; the current test of saving to a string filepath is here: https://github.com/altair-viz/altair/blob/4f6dd28b3d8d540533d59ad1b638f4da8480b87e/altair/vegalite/v4/tests/test_api.py#L284-L292

You could add another few lines of code below this to save via a path object as well.

@jakevdp
Copy link
Collaborator

jakevdp commented Dec 1, 2020

Looks great, thanks!

@jakevdp jakevdp merged commit 2aeab22 into vega:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Paths in save()
2 participants
@RoyalTS @jakevdp