-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and simplify README #2774
Conversation
…sts, not questions
…ted regarding frontends and fully contained in documentation
…pment sections and refer to documentation as readme gets stale quickly
Thanks for the work here. I'm trying to understand the changes you made to the file Can you explain a bit why you think that is necessary? Ah, maybe because you updated the requirements.txt as well. I think we still need |
There is also an Altair channel with >150 members in the Vega slack group. But it is not active. I think sticking to SO and GH is fine. |
…er is required for deployment as one thumbnail cannot be generated otherwise
I thought it's nice if we can switch to recommending vl-convert in
Consequently I also adapted it in I reverted the change in |
Yes, I agree. Everything outside building the docs should recommend using vl-convert. I think it’s possible to define/overrule an engine to be used to export the pngs. It would be a bit unpleasant if others have to delete packages for setting this. |
And with, building the docs I mean, the official one within GitHub actions. For contributors it really is much easier to use vl-convert. Therefor I’m also not against including it in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions
This PR is related to this: #2784 |
Co-authored-by: Mattijn van Hoek <[email protected]>
Co-authored-by: Mattijn van Hoek <[email protected]>
…en it needs to be uninstalled in favor of altair_saver
Thanks @mattijn! I agree, it's great if its easier for new contributors so I readded vl-convert-python to doc/requirements.txt and clarified in CONTRIBUTING.md when it needs to be replaced with altair_saver. In the github workflow, we can simply uninstall vl-convert-python. With this, it's only a bit cumbersome when releasing a new version but at least it's well documented. I'm not sure how it currently works with access rights to pypi and this repo, but a more reliable way to publish new versions and update the documentation would probably be with github workflows, e.g. see the Pandas repo wheels.yml and docbuild-and-upload.yml. |
I agree that streamlining the publication of releases to PyPi and Conda using Github Actions would be an improvement as it simplifies maintenance. Currently only Jake has the permissions to do so, perhaps creating a new issue to track this would be a good idea. It's likely that setting this up correctly will require some discussion to implement it properly. |
Co-authored-by: Mattijn van Hoek <[email protected]>
Sounds good, I'll create an issue with some first inputs for discussion. The GH actions might be a great way to share the credentials for pypi and conda between maintainers thereby reducing the single-person dependency risk on Jake. |
Co-authored-by: Mattijn van Hoek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you! A few minor comments
Co-authored-by: Joel Ostblom <[email protected]>
I updated the README.md. Furthermore, I really like READMEs which are concise, similar to https://github.com/pandas-dev/pandas, i.e. a README which summarizes what the library does, a fully contained example that can be copy-pasted, simple installation instructions, and a reference to the documentation. This is where users can then go to learn more. Afterwards, some additional content for developers. In my opinion, all the rest should be in the documentation so it's easier to find.
Reasoning for the changes is usually in the commit messages but let me know if anything is unclear!
Included content from #1122 in CONTRIBUTING.md
Is the Google Altair Group still something that should be actively recommended for asking questions or only StackOverflow? I think ideally there is one preferred place to ask questions (StackOverflow) and one place to report feature requests and bugs (GH issues). But as the Google Group already has quite some content, maybe we want to keep the reference to it and I could also add it in the Getting Help page in the documentation?