Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vega v5 wrappers #2829

Merged
merged 32 commits into from
Jan 25, 2023
Merged

Remove vega v5 wrappers #2829

merged 32 commits into from
Jan 25, 2023

Commits on Jan 8, 2023

  1. restructure, put template code together

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    637820a View commit details
    Browse the repository at this point in the history

  2. remove vega5 schema generation wrapper code

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    92af2c6 View commit details
    Browse the repository at this point in the history

  3. remove vega folder from altair

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    3d440ba View commit details
    Browse the repository at this point in the history

  4. remove vega v5 magic functions

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    cb72d6d View commit details
    Browse the repository at this point in the history

  5. remove vega as option for mimebundle

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    9c00973 View commit details
    Browse the repository at this point in the history

  6. remove vega as option for save.py

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    ecc8262 View commit details
    Browse the repository at this point in the history

  7. remove vega test from test_mimebundle

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    7b06730 View commit details
    Browse the repository at this point in the history

  8. remove vega tests folder

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    a628d06 View commit details
    Browse the repository at this point in the history

  9. update NOTES_FOR_MAINTAINERS

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    3e5fdf2 View commit details
    Browse the repository at this point in the history

  10. update pyproject and setup files

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    052750c View commit details
    Browse the repository at this point in the history

  11. remove vega tests from test_magics

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    f27234c View commit details
    Browse the repository at this point in the history

  12. remove vega docs from importing.rst

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    a288f35 View commit details
    Browse the repository at this point in the history

  13. remove test_vegalite_to_vega_mimebundle in test_mimebundle

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    6b82076 View commit details
    Browse the repository at this point in the history

  14. black

    @mattijn
    mattijn committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    c596abe View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. allow export format as vega in mimebundle.py

    @mattijn
    mattijn committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cbdb9a7 View commit details
    Browse the repository at this point in the history

  2. Revert "remove vega test from test_mimebundle" 

    This reverts commit 7b06730.
    @mattijn
    mattijn committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    260e766 View commit details
    Browse the repository at this point in the history

  3. Revert "remove test_vegalite_to_vega_mimebundle in test_mimebundle" 

    This reverts commit 6b82076.
    @mattijn
    mattijn committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    bca0c56 View commit details
    Browse the repository at this point in the history

  4. Revert "remove vega test from test_mimebundle" 

    This reverts commit 7b06730.
    @mattijn
    mattijn committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    718ee9a View commit details
    Browse the repository at this point in the history

  5. use not equal to over is not

    @mattijn
    mattijn committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    c535a1a View commit details
    Browse the repository at this point in the history

  6. allow vega as format but not as mode in save.py

    @mattijn
    mattijn committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    6bf8be9 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. change test_spec_to_vega_mimebundle 

    to test for deprecation warning and
to test for a valueerror
    @mattijn
    mattijn committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    dd1b1b4 View commit details
    Browse the repository at this point in the history

  2. mention mode 'vega-lite' as preferred in warning

    @mattijn
    mattijn committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    eff84c9 View commit details
    Browse the repository at this point in the history

  3. refactor save function

    @mattijn
    mattijn committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    702ebba View commit details
    Browse the repository at this point in the history

  4. add a line in release note

    @mattijn
    mattijn committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    b6fabee View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into remove-vega-v5-wrappers

    @mattijn
    mattijn authored Jan 15, 2023
    Configuration menu
    Copy the full SHA
    bf6b389 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Apply suggestions from code review 

    First round of improving the requested changes.

Co-authored-by: Stefan Binder <[email protected]>
    @mattijn @binste
    mattijn and binste authored Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1ed3f6f View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. remove warnings

    @mattijn
    mattijn committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f62ccdf View commit details
    Browse the repository at this point in the history

  2. remove warnings

    @mattijn
    mattijn committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5410da5 View commit details
    Browse the repository at this point in the history

  3. remove warning from test

    @mattijn
    mattijn committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    838896e View commit details
    Browse the repository at this point in the history

  4. solve conflicts to rebase

    @mattijn
    mattijn committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    32d581e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into remove-vega-v5-wrappers

    @mattijn
    mattijn authored Jan 25, 2023
    Configuration menu
    Copy the full SHA
    441db16 View commit details
    Browse the repository at this point in the history

  6. remove unused warnings package from import

    @mattijn
    mattijn committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    c009c2f View commit details
    Browse the repository at this point in the history