Fix incompatibility with jsonschema < 4.5 #2860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2857 for a 4.2.2 release. CC @mattijn. I already added a changelog entry but without release date. I think it makes sense to release this as soon as possible if you find the time.
Tests pass against the following jsonschema versions which cover the range which is relevant for Altair:
The
FORMAT_CHECKER
attribute on jsonschema validators was introduced in version 4.5 of jsonschema. Therefore, the compatibility looks as follows:FORMAT_CHECKER
attribute on validator classes which was only introduced in jsonschema 4.5This issue has already been fixed in the master branch in 29ad5e9.