-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use most specific class possible in schema validation errors #2883
Use most specific class possible in schema validation errors #2883
Conversation
…his is helpful in case error is based on e.g. StackOffset as a wrong parameter was passed to Y(stack='...') but what we actually want is channels.Y. Add tests
@joelostblom This already works if a wrong argument was passed to an encoding channel. Your example #2568 (comment) works anyway even without this PR because |
This is looking great! Thanks for getting to it so quickly @binste. I tried a few different examples and they all seem to work fine. One thing that I did notice is that if we use to datum encoding then their message is incorrect: alt.Chart().mark_point().encode(x=alt.datum(1, wrong_name=1))
|
Good to go from my side. I can review #2568 if you want once you merged in these changes. |
Addresses #2568 (comment)
Works already well but I'll still want to
jsonschema
versions (3, 4, 4.5, 4.16, 4.17)