Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use Facet/Trellis/Repeat consistently #3180

Merged
merged 12 commits into from
Sep 15, 2023
Merged

docs: Use Facet/Trellis/Repeat consistently #3180

merged 12 commits into from
Sep 15, 2023

Commits on Aug 30, 2023

  1. example: update trellis_area to use facet 

    See vega#3178

This removes the old trellis_area example, because that is just a
simpler version of the sorted version.
Might as well just have the sorted version,
it is easy enough to see how you would jusst remove the sort
to get back to the original example.

This also adds some commas to the code so that
black keeps the formatting the same.

I wanted to update the name of the example so that it didn't contain
the word "trellis". While
I was at it I also wanted the examples to be in better sort order.
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    80f8662 View commit details
    Browse the repository at this point in the history

  2. example: Use facet in trellist_stacked_bar_chart 

    See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a348b02 View commit details
    Browse the repository at this point in the history

  3. example: Use facet in bar_chart_trellis_compact 

    See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    7a90459 View commit details
    Browse the repository at this point in the history

  4. example: Use facet in trellis_scatter_plot 

    See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    e264009 View commit details
    Browse the repository at this point in the history

  5. example: Use facet in trellis_histogram 

    See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    7ee7297 View commit details
    Browse the repository at this point in the history

  6. example: Use facet in beckers_barley_trellis_plot 

    See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    144047e View commit details
    Browse the repository at this point in the history

  7. example: Remove trellis in beckers_barley_wrapped 

    See vega#3178

This also re-categorizes this example as a case study.
I think this makes more sense, as it puts it with the other
beckers barley example.
And there aren't really any advance calculations
going on.
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6a4dfa6 View commit details
    Browse the repository at this point in the history

  8. example: remove facet in density_facet 

    This isn't an example of faceting, but repeating.

See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d5c0b10 View commit details
    Browse the repository at this point in the history

  9. example: Fix "facet" use in scatter_marginal_hist 

    The scatter plot is not faceted, but the
marginal scatter plots are, with
one histogram for eadch subset.

See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8a2903f View commit details
    Browse the repository at this point in the history

  10. example: Use facet in ridgeline_plot 

    This is using faceting, so let's
call it out explicitly so people
learn the terminology.

See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    731e33f View commit details
    Browse the repository at this point in the history

  11. example: Use facet in anscombe_plot 

    See vega#3178
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    f69cb81 View commit details
    Browse the repository at this point in the history

  12. docs: Link to "trellis" etc in definition of Facet 

    See vega#3178

Also improve the intro to Faceted charts.
    @NickCrews
    NickCrews committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d3ca696 View commit details
    Browse the repository at this point in the history