Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints: Infer types from vegalite schema for autogenerated code #3208

Merged
merged 52 commits into from
Nov 22, 2023
Merged

Type hints: Infer types from vegalite schema for autogenerated code #3208

merged 52 commits into from
Nov 22, 2023

Commits on Sep 29, 2023

  1. Include schema files in mypy type checking

    @binste
    binste committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8279a1d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into autoinfer_types

    @binste
    binste committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    00fff06 View commit details
    Browse the repository at this point in the history

  3. Use actual names of Python types in docstrings

    @binste
    binste committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    28b5727 View commit details
    Browse the repository at this point in the history

  4. Simplify medium_description by removing unused code paths

    @binste
    binste committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    afaa49f View commit details
    Browse the repository at this point in the history

  5. Use Python type hint syntax instead of pseudo jsonschema syntax in do… 

    …cstrings
    @binste
    binste committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3edb68d View commit details
    Browse the repository at this point in the history

  6. First version of autoinferred type hints

    @binste
    binste committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fb81f4e View commit details
    Browse the repository at this point in the history

  7. Various improvements

    @binste
    binste committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8662430 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Add type hints to mixins.py

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    6d60cf3 View commit details
    Browse the repository at this point in the history

  2. Bug fix: Add missing overload operators

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    7d945d7 View commit details
    Browse the repository at this point in the history

  3. Add type hints to arguments of overload signatures where the signatur… 

    …e has multiple arguments with Undefined default value
    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    b6d5c6a View commit details
    Browse the repository at this point in the history

  4. Add type hint for Parameter

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    161d47b View commit details
    Browse the repository at this point in the history

  5. Deduplicate type hints

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    f02518b View commit details
    Browse the repository at this point in the history

  6. Minor renaming and reordering of type hints

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    581ae27 View commit details
    Browse the repository at this point in the history

  7. Recursively go through types to get all for type hints as well as doc… 

    …strings
    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    6f7a6ef View commit details
    Browse the repository at this point in the history

  8. Instead of writing a List of Unions, do it the other way around and d… 

    …o not allow for combinations of different types in lists. This deals with the invariance of lists
    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    a66e070 View commit details
    Browse the repository at this point in the history

  9. Use Sequence instead of List

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    30d9ea0 View commit details
    Browse the repository at this point in the history

  10. Simplify code

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    c565fe4 View commit details
    Browse the repository at this point in the history

  11. Remove unused ignore statement. Seems like mypy can now correctly det… 

    …ect that the overload statements are correct
    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    10764db View commit details
    Browse the repository at this point in the history

  12. Switch to tooltip specification which conforms to type hints

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    54439c8 View commit details
    Browse the repository at this point in the history

  13. Ignore mypy errors when it cannot detect the existence of the .copy m… 

    …ethod
    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    8d212d6 View commit details
    Browse the repository at this point in the history

  14. Explicitly pass kwarg arguments in these examples

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    788bf8d View commit details
    Browse the repository at this point in the history

  15. Fix schema for 'shorthand' as it also accepts an array of strings

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    fdadf95 View commit details
    Browse the repository at this point in the history

  16. Revert "Switch to tooltip specification which conforms to type hints" 

    This reverts commit 54439c8.
    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    879365d View commit details
    Browse the repository at this point in the history

  17. Fix some more mypy errors

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    513709f View commit details
    Browse the repository at this point in the history

  18. Ignore mypy overload errors

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    e0c841e View commit details
    Browse the repository at this point in the history

  19. Black and ruff

    @binste
    binste committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    0e803bc View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. Add type hints to channel mixins

    @binste
    binste committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    ebaaee2 View commit details
    Browse the repository at this point in the history

  2. Simplify docstrings by removing Union so they look better in docs. Re… 

    …move type hints from signatures in docs as they are already shown in docstrings
    @binste
    binste committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    7bdf2a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Merge branch 'main' into autoinfer_types

    @binste
    binste committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    d964fa1 View commit details
    Browse the repository at this point in the history

  2. Fix merge conflicts and rerun schema generation

    @binste
    binste committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    4a2d77a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. Remove redundat capability with VL v2

    @binste
    binste committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    2a3031a View commit details
    Browse the repository at this point in the history

  2. Factor out adding shorthand into a separate function. Fix missing Fie… 

    …ld class definitions in docstring where previously only shorthand was shown
    @binste
    binste committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f99e19c View commit details
    Browse the repository at this point in the history

  3. Add missing shorthand to field definitions in core.py

    @binste
    binste committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    c9ece69 View commit details
    Browse the repository at this point in the history

  4. Add shorthand str and list[str] type hints to signature of encode method

    @binste
    binste committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    9a0e96b View commit details
    Browse the repository at this point in the history

  5. Fix various mypy errors

    @binste
    binste committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    a19f846 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Fix mypy error for data argument. Add RepeatRef as a type hint for sh… 

    …orthand
    @binste
    binste committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    18d96e4 View commit details
    Browse the repository at this point in the history

  2. Add _ParameterProtocol wherever ParameterExtent is accepted

    @binste
    binste committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    bbc9d50 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into autoinfer_types

    @binste
    binste committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    76d4457 View commit details
    Browse the repository at this point in the history

  4. Switch to ruff as code formatter

    @binste
    binste committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    c4fcbe2 View commit details
    Browse the repository at this point in the history

  5. Ruff fix

    @binste
    binste committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d334a1e View commit details
    Browse the repository at this point in the history

  6. Move type ignore comment which was shifted by Ruff

    @binste
    binste committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3b4703a View commit details
    Browse the repository at this point in the history

  7. Try to fix mypy issue in pipeline which does not appear locally

    @binste
    binste committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3e28f3f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Change type signature of encode method to only include the types whic… 

    …h users expect
    @binste
    binste committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    58f486b View commit details
    Browse the repository at this point in the history

  2. Only show type hints for datum and value if they are accepted

    @binste
    binste committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    cadcf57 View commit details
    Browse the repository at this point in the history

  3. Fix trailing whitespace

    @binste
    binste committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3526c36 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Switch back to just 'dict'

    @binste
    binste committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8209f75 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Add type hint for list to encoding channels which support it

    @binste
    binste committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    0292f14 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Rename _ParameterProtocol to _Parameter

    @binste
    binste committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    dc4194d View commit details
    Browse the repository at this point in the history

  2. Fix ruff error

    @binste
    binste committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e76dd42 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Add parameters incl. type hints to docstrings. Without descriptions f… 

    …or now
    @binste
    binste committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    8116657 View commit details
    Browse the repository at this point in the history

  2. Add descriptions

    @binste
    binste committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    e4f3073 View commit details
    Browse the repository at this point in the history

  3. Change import statement for expr.core to help type checkers

    @binste
    binste committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    c364b78 View commit details
    Browse the repository at this point in the history