Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display search keyboard shortcut on home page #3220

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

joelostblom
Copy link
Contributor

There are a few style changes in the latest pydata sphinx theme. The Altair docs home page looks like this:

image

After the changes in the latest pydata version it will look like this:

image

I like the centered navigation titles, but think the different color banner goes less well with the altair logo (although I don't feel strongly about this), and I definitely don't like that a keyboard shortcut is being displayed in the search box by default. After this PR, the home page looks like this:

image

Once you click the search box, the keyboard shortcut still shows up:

image

I tried changing back the header color also, but couldn't quite figure out how to do it and want to avoid putting too much time into changing CSS rules. I tried something like this

/* with and without ":after" */
.bd-header-announcement:after {
    background-color: #daebf1 !important;
}

Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joelostblom! I agree that it looks better without the shortcut and that the blue color is better for our docs.

The CSS you provided works well for me if I include it in custom.css:

.bd-header-announcement:after {
    background-color: #daebf1 !important;
}

Could you give it another try? Maybe your browser cached the css? Otherwise, looks good to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the latest version as a minimum requirement in pyproject.toml to make sure that we use it from now on? "pydata-sphinx-theme>=0.14.1",

@joelostblom
Copy link
Contributor Author

You're right, it must have been cached in my browser. I didn't even need the after part. Merging when tests are passing.

@joelostblom joelostblom merged commit 0ca8378 into main Oct 9, 2023
20 checks passed
@mattijn mattijn mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants