-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Vega-Lite 5.16.3 #3273
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b1414cd
Run /generate_schema_wrapper.py with hatch run
jonmmease 44e4020
Merge remote-tracking branch 'origin/main' into jonmmease/vega-lite-5…
jonmmease b432738
Update Vega-Lite to 5.16.3 and run generate_schema_wrapper.py
jonmmease 450e3ed
Update Vega-Lite to 5.16.3 in JupyterChart
jonmmease 343808f
Bump min vl-convert-python version
jonmmease 7848206
Add release note on Vega-Lite version update
jonmmease 1d31daa
Update to_url test
jonmmease 991a0f1
Fix heading level
jonmmease c84e90e
Link to general Vega-Lite release notes
jonmmease File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ All the files within these directories are created automatically by running | |
the following script from the root of the repository: | ||
|
||
```bash | ||
$ python tools/generate_schema_wrapper.py | ||
$ hatch run python tools/generate_schema_wrapper.py | ||
``` | ||
|
||
This script does a couple things: | ||
|
@@ -49,10 +49,12 @@ of some docstrings. | |
Major version updates (e.g. Vega-Lite 1.X->2.X) have required substantial | ||
rewrites, because the internal structure of the schema changed appreciably. | ||
|
||
## Updating the Vega-Lite in JupyterChart | ||
To update the Vega-Lite version used in JupyterChart, update the version in the esm.sh URL in `altair/jupyter/js/index.js`. | ||
### Updating the Vega-Lite in JupyterChart | ||
To update the Vega-Lite version used in JupyterChart, update the version in the | ||
esm.sh URL in `altair/jupyter/js/index.js`. | ||
|
||
For example, to update to Vega-Lite 5.15.1, Vega 5 and Vega-Embed 6, the URL should be: | ||
For example, to update to Vega-Lite 5.15.1, Vega 5 and Vega-Embed 6, the URL | ||
should be: | ||
|
||
```javascript | ||
import embed from "https://esm.sh/vega-embed@6?deps=vega@5&[email protected]"; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import embed from "https://esm.sh/vega-embed@6?deps=vega@5&deps=vega-lite@5.15.1"; | ||
import embed from "https://esm.sh/vega-embed@6?deps=vega@5&deps=vega-lite@5.16.3"; | ||
import debounce from "https://esm.sh/[email protected]/debounce"; | ||
|
||
export async function render({ model, el }) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link here just to the general release notes page (https://github.com/vega/vega-lite/releases) as it's more then just the 5.16.3 changes?