Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax type hint for 'indent' in to_json method #3342

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Relax type hint for 'indent' in to_json method #3342

merged 1 commit into from
Feb 27, 2024

Conversation

binste
Copy link
Contributor

@binste binste commented Feb 25, 2024 •
edited
Loading

Closes #3341

jonmmease
jonmmease approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@binste binste merged commit e58e8cb into vega:main Feb 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmmease jonmmease jonmmease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type hint for to_json(indent=) should be Optional
2 participants
@binste @jonmmease