refactor(typing): Reuse generated Literal aliases in api
#3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following vega#3431 a number of these are now importable. Additionally, I spotted the `encodings` parameter was annotated with `str`, but should be restricted to the constraints of `SingleDefUnitChannel_T`.
dangotbanned
commented
Jul 8, 2024
| @@ -3061,7 +3062,7 @@ def interactive( | |||
| copy of self, with interactive axes added | |||
|
|
|||
| """ | |||
| encodings = [] | |||
| encodings: list[SingleDefUnitChannel_T] = [] | |||
There was a problem hiding this comment.
I've only annotated the 4x of these to satisfy mypy.
|
Thanks for further simplifying the maintenance of the type hints! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3431 a number of these are now importable.
Additionally, I spotted the
encodingsparameter (e.g. inselection_point) was annotated withstr, but should be constrained to onlySingleDefUnitChannel_T.