-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typing): Fully annotate api.py
#3508
Commits on Jul 28, 2024
-
ci(ruff): Add
ANN
rules forapi.py
onlyTo highlight all the missing annotations to fix and autofix `None` return
Configuration menu - View commit details
-
Copy full SHA for fde0696 - Browse repository at this point
Copy the full SHA fde0696View commit details
Commits on Jul 29, 2024
-
feat(typing): Complete annotations for most
api
functionsExcluding `*args` on `ChartType` wrappers. They need to be defined in alignment in multiple places, which is more complex
Configuration menu - View commit details
-
Copy full SHA for cb1707e - Browse repository at this point
Copy the full SHA cb1707eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a32c937 - Browse repository at this point
Copy the full SHA a32c937View commit details -
feat(typing): Various changes to enforce
dict[str, Any]
instead of ……`dict` Among these, many locations already assume `str` keys in the implementation - without checking
Configuration menu - View commit details
-
Copy full SHA for de2fe9f - Browse repository at this point
Copy the full SHA de2fe9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20f9d85 - Browse repository at this point
Copy the full SHA 20f9d85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cfcd5c - Browse repository at this point
Copy the full SHA 8cfcd5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e20e426 - Browse repository at this point
Copy the full SHA e20e426View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0184c7f - Browse repository at this point
Copy the full SHA 0184c7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ef1ed6 - Browse repository at this point
Copy the full SHA 3ef1ed6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 591d322 - Browse repository at this point
Copy the full SHA 591d322View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94ef3a5 - Browse repository at this point
Copy the full SHA 94ef3a5View commit details -
fix(typing): Resolve Liskov violations
``` altair\vegalite\v5\api.py:4368: error: Argument 1 of "__iadd__" is incompatible with "__add__" of supertype "TopLevelMixin"; supertype defines the argument type as "Chart | RepeatChart | ConcatChart | HConcatChart | VConcatChart | FacetChart | LayerChart" [override] def __iadd__(self, other: LayerChart | Chart) -> Self: ^~~~~~~~~~~~~~~~~~~~~~~~~ altair\vegalite\v5\api.py:4368: note: This violates the Liskov substitution principle altair\vegalite\v5\api.py:4368: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides altair\vegalite\v5\api.py:4376: error: Argument 1 of "__add__" is incompatible with supertype "TopLevelMixin"; supertype defines the argument type as "Chart | RepeatChart | ConcatChart | HConcatChart | VConcatChart | FacetChart | LayerChart" [override] def __add__(self, other: LayerChart | Chart) -> Self: ^~~~~~~~~~~~~~~~~~~~~~~~~ altair\vegalite\v5\api.py:4376: note: This violates the Liskov substitution principle altair\vegalite\v5\api.py:4376: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides ```
Configuration menu - View commit details
-
Copy full SHA for 470a490 - Browse repository at this point
Copy the full SHA 470a490View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8287f5e - Browse repository at this point
Copy the full SHA 8287f5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00985dc - Browse repository at this point
Copy the full SHA 00985dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 831d653 - Browse repository at this point
Copy the full SHA 831d653View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60281f5 - Browse repository at this point
Copy the full SHA 60281f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d3fd1e - Browse repository at this point
Copy the full SHA 3d3fd1eView commit details -
This could later be extended to other modules, but for now `api` is complete.
Configuration menu - View commit details
-
Copy full SHA for 010d4fb - Browse repository at this point
Copy the full SHA 010d4fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26fd795 - Browse repository at this point
Copy the full SHA 26fd795View commit details
Commits on Jul 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8e27862 - Browse repository at this point
Copy the full SHA 8e27862View commit details -
fix(typing): Add missing
FacetChart
annotationsTo align with the other `ChartType`s
Configuration menu - View commit details
-
Copy full SHA for c5ab6f0 - Browse repository at this point
Copy the full SHA c5ab6f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1803550 - Browse repository at this point
Copy the full SHA 1803550View commit details
Commits on Jul 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 18c014e - Browse repository at this point
Copy the full SHA 18c014eView commit details