refactor: Simplify unreachable compound chart cases #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts with most of the test suite and all examples. `ruff` handles this anyway
dangotbanned
changed the title
Reaching `_check_if_can_be_layered` requires passing `_check_if_valid_subspec` - which already raises if not `SchemaBase`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3518
Related
api.py#3508Note
See links in
1fdfe90(#3520) for more info on theValueError->TypeError.It is a subclass so this doesn't affect anything downstream, and is more consistent with
stdlibdefinition.