Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Vega-Lite to 5.20.1 #3525

Merged
merged 5 commits into from
Aug 11, 2024
Merged

feat: Update Vega-Lite to 5.20.1 #3525

merged 5 commits into from
Aug 11, 2024

Conversation

binste
Copy link
Contributor

@binste binste commented Aug 7, 2024

Compared to 5.19, it includes the new parameters react and tickBandPaddingInner.

Edit: I'll need to update the tests next. Note to myself to also update NOTES_FOR_MAINTAINERSE.md to mention this.

@binste binste marked this pull request as draft August 7, 2024 06:01
@jonmmease
Copy link
Contributor

@binste, feel free to update the tests/vegalite/v5/test_api.py::test_to_url test to to only check the start of the URL (the way we do when checking PNG/SVG images). Testing that the full URL is accurate is really vl-convert's responsibility, so I don't think we need to check the whole thing here, especially since it breaks on every Vega-Lite update.

@binste
Copy link
Contributor Author

binste commented Aug 8, 2024

Good point! Changed it

@binste binste marked this pull request as ready for review August 8, 2024 17:33
@binste binste requested a review from jonmmease August 8, 2024 17:34
@binste binste merged commit 2fcb77e into vega:main Aug 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants