Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update Vega-Lite to version 2.5 #923

Merged
merged 3 commits into from
Jun 12, 2018
Merged

WIP: update Vega-Lite to version 2.5 #923

merged 3 commits into from
Jun 12, 2018

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Jun 7, 2018

A few tasks before merging

  • wrap new field predicates (actually, field predicates are not wrapped at the moment; see Better access to logical operand predicates #695)
  • handle .dsv data format
  • deal with SortField backward incompatibility somehow?
  • update docs on above features

@jakevdp
Copy link
Collaborator Author

jakevdp commented Jun 8, 2018

I can't think of any good way to deal with the SortField change. If SortField were now not used in the schema, we could alias it to EncodingSortField so that old code will continue working. But since SortField still exists but refers to something different, that will serve to create confusion in the case that someone wants to use the new version of SortField.

I think we just need to stomach the API breakage and move on, though it will cause issues for some people when upgrading from 2.1 to 2.2.

I know @palewire has used SortField before, and others probably have too...

@kanitw
Copy link
Member

kanitw commented Jun 8, 2018

We could think of another name and rename SortField in VL.

Ill be out of town for a week though so might nit be able to change that until i cole back

@palewire
Copy link
Contributor

palewire commented Jun 8, 2018

At this stage, I'm okay with eating API changes. I just wouldn't want to lose the functionality. What is it changing to?

@jakevdp
Copy link
Collaborator Author

jakevdp commented Jun 12, 2018

OK, I think we'll just swallow the SortField -> EncodingSortField change at this point, then.

@jakevdp jakevdp merged commit 1e62dc0 into vega:master Jun 12, 2018
@jakevdp jakevdp deleted the vl-2.5 branch June 12, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants