fix: conditional-generic-default (#1830)

src/Utils/nodeKey.ts

@@ -52,5 +52,5 @@ export function getKey(node: Node, context: Context): string {
     const id = ids.join("-");
     const args = context.getArguments();
 
-    return args.length ? `${id}<${args.map((arg) => arg.getId()).join(",")}>` : id;
+    return args.length ? `${id}<${args.map((arg) => arg?.getId()).join(",")}>` : id;
 }

test/valid-data-other.test.ts

@@ -63,6 +63,7 @@ describe("valid-data-other", () => {
     it("generic-anonymous", assertValidSchema("generic-anonymous", "MyObject"));
     it("generic-recursive", assertValidSchema("generic-recursive", "MyObject"));
     it("generic-hell", assertValidSchema("generic-hell", "MyObject"));
+    it("generic-default-conditional", assertValidSchema("generic-default-conditional", "MyObject"));
     it("generic-default", assertValidSchema("generic-default", "MyObject"));
     it("generic-nested", assertValidSchema("generic-nested", "MyObject"));
     it("generic-prefixed-number", assertValidSchema("generic-prefixed-number", "MyObject"));

test/valid-data/generic-default-conditional/main.ts

@@ -0,0 +1,5 @@
+export type MyObject = ConditionalGeneric;
+
+export type ConditionalGeneric<T = string extends 'foo' ? 'bar' : 'baz'> = {
+    foo: T;
+}

test/valid-data/generic-default-conditional/schema.json

@@ -0,0 +1,22 @@
+{
+  "$ref": "#/definitions/MyObject",
+  "$schema": "http://json-schema.org/draft-07/schema#",
+  "definitions": {
+    "ConditionalGeneric": {
+      "additionalProperties": false,
+      "properties": {
+        "foo": {
+          "type": "string",
+          "const": "baz"
+        }
+      },
+      "required": [
+        "foo"
+      ],
+      "type": "object"
+    },
+    "MyObject": {
+      "$ref": "#/definitions/ConditionalGeneric"
+    }
+  }
+}