Skip to content

Commit

Permalink
Keep params at the top level
Browse files Browse the repository at this point in the history
  • Loading branch information
domoritz committed Feb 8, 2024
1 parent 25fcca2 commit 6b68998
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/normalize/pathoverlay.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export class PathOverlayNormalizer implements NonFacetUnitNormalizer<UnitSpecWit

public run(spec: UnitSpecWithPathOverlay, normParams: NormalizerParams, normalize: NormalizeLayerOrUnit) {
const {config} = normParams;
const {params, projection, mark, name, encoding: e, ...outerSpec} = spec;
const {projection, mark, name, encoding: e, ...outerSpec} = spec;

// Need to call normalizeEncoding because we need the inferred types to correctly determine stack
const encoding = normalizeEncoding(e, config);
Expand All @@ -116,7 +116,6 @@ export class PathOverlayNormalizer implements NonFacetUnitNormalizer<UnitSpecWit
const layer: NormalizedUnitSpec[] = [
{
name,
...(params ? {params} : {}),
mark: dropLineAndPoint({
// TODO: extract this 0.7 to be shared with default opacity for point/tick/...
...(markDef.type === 'area' && markDef.opacity === undefined && markDef.fillOpacity === undefined
Expand Down

0 comments on commit 6b68998

Please sign in to comment.