respond to comments

vega · Jul 19, 2023 · ae87cb4 · ae87cb4
1 parent 1dfd3b7
commit ae87cb4
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 15 deletions.
diff --git a/build/vega-lite-schema.json b/build/vega-lite-schema.json
@@ -21911,9 +21911,6 @@
         },
         "scheme": {
           "anyOf": [
-            {
-              "type": "string"
-            },
             {
               "$ref": "#/definitions/ColorScheme"
             },
@@ -22471,14 +22468,7 @@
           "type": "array"
         },
         "name": {
-          "anyOf": [
-            {
-              "type": "string"
-            },
-            {
-              "$ref": "#/definitions/ColorScheme"
-            }
-          ],
+          "$ref": "#/definitions/ColorScheme",
           "description": "A color scheme name for ordinal scales (e.g., `\"category10\"` or `\"blues\"`).\n\nFor the full list of supported schemes, please refer to the [Vega Scheme](https://vega.github.io/vega/docs/schemes/#reference) reference."
         }
       },

diff --git a/package.json b/package.json
@@ -127,7 +127,6 @@
     "vega-datasets": "^2.7.0",
     "vega-embed": "^6.22.1",
     "vega-tooltip": "^0.32.0",
-    "vega-typings": "^0.24.1",
     "yaml-front-matter": "^4.1.1"
   },
   "dependencies": {

diff --git a/src/scale.ts b/src/scale.ts
@@ -459,7 +459,7 @@ export interface SchemeParams {
    *
    * For the full list of supported schemes, please refer to the [Vega Scheme](https://vega.github.io/vega/docs/schemes/#reference) reference.
    */
-  name: string | ColorScheme | SignalRef;
+  name: ColorScheme | SignalRef;
 
   /**
    * The extent of the color range to use. For example `[0.2, 1]` will rescale the color scheme such that color values in the range _[0, 0.2)_ are excluded from the scheme.
@@ -611,7 +611,7 @@ export interface Scale<ES extends ExprRef | SignalRef = ExprRef | SignalRef> {
    *
    * For the full list of supported schemes, please refer to the [Vega Scheme](https://vega.github.io/vega/docs/schemes/#reference) reference.
    */
-  scheme?: string | ColorScheme | SchemeParams | ES;
+  scheme?: ColorScheme | SchemeParams | ES;
 
   /**
    * The alignment of the steps within the scale range.

diff --git a/yarn.lock b/yarn.lock
@@ -9015,7 +9015,7 @@ vega-transforms@~4.10.2:
     vega-time "^2.1.1"
     vega-util "^1.17.1"
 
-vega-typings@^0.24.1, vega-typings@~0.24.0:
+vega-typings@~0.24.0:
   version "0.24.1"
   resolved "https://registry.yarnpkg.com/vega-typings/-/vega-typings-0.24.1.tgz#7e1e87557a9bf09e934687197c5e964bd9b416ca"
   integrity sha512-WNw6tDxwMsynQ9osJb3RZi3g8GZruxVgXfe8N7nbqvNOgDQkUuVjqTZiwGg5kqjmLqx09lRRlskgp/ov7lEGeg==