Do not ignore x2's title #3766
Merged
Do not ignore x2's title #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
approved these changes
May 18, 2018
| @@ -130,6 +130,24 @@ describe('Axis', function() { | |||
| } | |||
| }); | |||
|
|
|||
| it('should store the fieldDef title value if title = null, "", or false', function () { | |||
There was a problem hiding this comment.
why not use an arrow function here
There was a problem hiding this comment.
You gonna call another clean all service later anyway, so I'll ignore this :p
| const model = parseUnitModelWithScale({ | ||
| mark: "bar", | ||
| encoding: { | ||
| x: { |
There was a problem hiding this comment.
Let's add a test where only x and only x2 have a title defined.
There was a problem hiding this comment.
That doesn't work for other reasons, and I'm not gonna fix it in this PR. Feel free to file another issue.
domoritz
reviewed
May 19, 2018
src/compile/axis/parse.ts
Outdated
| return title1; | ||
| } else if (title2) { | ||
| return title2; | ||
| } else if (title1 !== undefined) { |
There was a problem hiding this comment.
What is this about? Can you add a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3742