Fix logic for window’s default as #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(_field was wrong)
domoritz
reviewed
May 24, 2018
src/compile/data/window.ts
Outdated
| @@ -26,7 +26,8 @@ export class WindowTransformNode extends DataFlowNode { | |||
| } | |||
|
|
|||
| private getDefaultName(windowFieldDef: WindowFieldDef): string { | |||
| return windowFieldDef.as === undefined ? String(windowFieldDef.op) + '_field' : windowFieldDef.as; | |||
| const {as, op, field} = windowFieldDef; | |||
| return as || (field ? `${op}_${field}` : op); | |||
There was a problem hiding this comment.
Does this work with nested fields? Why not use vgField?
domoritz
approved these changes
May 24, 2018
kanitw
commented
May 24, 2018
src/compile/data/window.ts
Outdated
| @@ -26,7 +27,8 @@ export class WindowTransformNode extends DataFlowNode { | |||
| } | |||
|
|
|||
| private getDefaultName(windowFieldDef: WindowFieldDef): string { | |||
| return windowFieldDef.as === undefined ? String(windowFieldDef.op) + '_field' : windowFieldDef.as; | |||
| const {as, op} = windowFieldDef; | |||
| return as || vgField(windowFieldDef, {op}); | |||
There was a problem hiding this comment.
Actually this still seems hacky.... let me refactor more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_fieldwas wrong as multiple fields can have the same aggregate op