Rename FieldDef.ts => ChannelDef.ts #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why?: It includes ValueDef, which is not a field def. So this is a clearer. name.
|
@kanitw You broke my repo build. lol. But I also thought about renaming the file the same way so can forgive u for this. |
|
☝️ brotherly love! |
|
Yeah, note that we use semantic versioning for our JSON syntax, but not for internal files. (We will bump the major version if the JSON syntax has breaking change, but we won't bump the major version if we rename our source code files / methods.) Thus, if you import our code files directly, better not use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?: It includes ValueDef, which is not a field def. So this is a clearer. name.