Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restrict pivot transform's op to aggregates #7199

Merged
merged 2 commits into from
Jan 31, 2021
Merged

fix: restrict pivot transform's op to aggregates #7199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f644e8
fix: restrict pivot transform's op to aggregates
domoritz Jan 31, 2021
1db5053
chore: update schema [CI]
Jan 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/vega-lite-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18648,8 +18648,8 @@
"type": "number"
},
"op": {
"description": "The aggregation operation to apply to grouped `value` field values. __Default value:__ `sum`",
"type": "string"
"$ref": "#/definitions/AggregateOp",
"description": "The aggregation operation to apply to grouped `value` field values. __Default value:__ `sum`"
},
"pivot": {
"$ref": "#/definitions/FieldName",
Expand Down
2 changes: 1 addition & 1 deletion src/transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ export interface PivotTransform {
* The aggregation operation to apply to grouped `value` field values.
* __Default value:__ `sum`
*/
op?: string;
op?: AggregateOp;
}

export function isPivot(t: Transform): t is PivotTransform {
Expand Down