Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added draft theme for the Los Angeles Times #16

Merged
merged 14 commits into from
Feb 11, 2019
Merged

Conversation

palewire
Copy link
Contributor

screenshot from 2019-02-10 11-38-12

@domoritz
Copy link
Member

domoritz commented Feb 10, 2019

@palewire This is fantastic. Thank you! I look forward to reviewing it once the tests pass. You should be able to run yarn format to fix linting issues.

@palewire
Copy link
Contributor Author

When I run yarn lint it's throwing an error but not giving me any traceback.

$ yarn lint
yarn run v1.13.0
$ tslint -p . && prettier --list-different '{src,test}/**/*.ts'
src/theme-latimes.ts
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Here's what happens if I run your command.

$ yarn run fix
yarn run v1.13.0
error Command "fix" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Any tips?

@domoritz
Copy link
Member

When I run yarn lint it's throwing an error but not giving me any traceback.

I just fixed that in master. Prettier recently added support for --check.

@domoritz
Copy link
Member

domoritz commented Feb 10, 2019

Sorry, the command is yarn format. 😇

@palewire
Copy link
Contributor Author

Done.

@domoritz domoritz merged commit f516ac8 into vega:master Feb 11, 2019
@domoritz
Copy link
Member

domoritz commented Feb 11, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants