SQL refactor #160
Merged
SQL refactor #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the SqlDataFrame can check whether a query is supported by the connection's dialect on its own.
Have SqlDataFrame provide the name of the parent table to use when buiding queries
Rename SqlDatabaseConnection to SqlConnection
Use timestamptz_to_timestamp to change timezone in the Vega timeFormat function
Add back quarter/day/dayofyear expression functions
This reverts commit 6ceafc6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards the SQL integration detailed in #151.
No support for external engines is included in this PR, but it includes a significant refactor of all Vega transform implementations to generate SQL (using the
SqlDataFramestruct) rather than making direct use of the DataFusionDataFrameAPI. Presently, this SQL is executed exclusively by the DataFusion query engine, but the extension points are here to add support for specific SQL engines in future PRs.