Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to handle null Timestamp values.
Issue: The arrow
unary
function can be used to map a unary function across a primitive array, propagating the nulls mask. The docs forunary
state that the function must be infallible because it will be evaluated with whatever happens to be stored in the data array for null values. The issue is thattimestamp_to_timestamptz
UDF performs a timezone conversion, and so it is not valid for arbitrary i32 array elements.Solution: Switch to using
array.iter().map()
to map over boxedOptional
array element values. This way we only perform the timezone conversions on valid timestamp values.