Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno_fetch BorrowMutError with 0.11.1 #78

Closed
jonmmease opened this issue Jun 30, 2023 · 1 comment · Fixed by #82
Closed

deno_fetch BorrowMutError with 0.11.1 #78

jonmmease opened this issue Jun 30, 2023 · 1 comment · Fixed by #82
Labels
bug Something isn't working

Comments

@jonmmease
Copy link
Collaborator

jonmmease commented Jun 30, 2023 •
edited
Loading

After updating from 0.10.3 to 0.11.1, the Altair CI tests are failing flakily with this error:

thread 'tokio-runtime-worker' panicked at 'already borrowed: BorrowMutError', /Users/jonmmease/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_fetch-0.132.0/lib.rs:453:6
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(262), ...)', /Users/jonmmease/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.190.0/runtime.rs:2432:50

stack backtrace:
   0:        0x178465454 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   1:        0x178071b18 - _BrotliDecoderVersion
   2:        0x1784438c4 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   3:        0x178469384 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   4:        0x178468fe4 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   5:        0x178469ed0 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   6:        0x178469a80 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   7:        0x1784699f0 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   8:        0x1784699e4 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   9:        0x17958ca1c - _v8_inspector__V8InspectorClient__BASE__consoleAPIMessage
  10:        0x17958cc68 - _v8_inspector__V8InspectorClient__BASE__consoleAPIMessage
  11:        0x17810410c - _BrotliDecoderVersion
  12:        0x1781068d0 - _BrotliDecoderVersion
  13:        0x17809f8f8 - _BrotliDecoderVersion
  14:        0x1780b6a70 - _BrotliDecoderVersion
  15:        0x178493b54 - _rustsecp256k1_v0_8_1_default_error_callback_fn
  16:        0x178492aa8 - _rustsecp256k1_v0_8_1_default_error_callback_fn
  17:        0x1784a05a0 - _rustsecp256k1_v0_8_1_default_error_callback_fn
  18:        0x17849801c - _rustsecp256k1_v0_8_1_default_error_callback_fn
  19:        0x178497bf0 - _rustsecp256k1_v0_8_1_default_error_callback_fn
  20:        0x178498580 - _rustsecp256k1_v0_8_1_default_error_callback_fn
  21:        0x17846bc80 - _rustsecp256k1_v0_8_1_default_error_callback_fn
  22:        0x19c227fa8 - __pthread_joiner_wake
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(137), ...)', /Users/jonmmease/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.190.0/runtime.rs:2432:50
stack backtrace:
   0:        0x178465454 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   1:        0x178071b18 - _BrotliDecoderVersion
   2:        0x1784438c4 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   3:        0x178469384 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   4:        0x178468fe4 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   5:        0x178469ed0 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   6:        0x178469a80 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   7:        0x1784699f0 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   8:        0x1784699e4 - _rustsecp256k1_v0_8_1_default_error_callback_fn
   9:        0x17958ca1c - _v8_inspector__V8InspectorClient__BASE__consoleAPIMessage
  10:        0x17958cc68 - _v8_inspector__V8InspectorClient__BASE__consoleAPIMessage
  11:        0x1780a923c - _BrotliDecoderVersion
  12:        0x17851b9cc - _v8_inspector__V8InspectorClient__BASE__consoleAPIMessage
  13:        0x17851d06c - _v8_inspector__V8InspectorClient__BASE__consoleAPIMessage
  14:        0x178516f50 - _v8_inspector__V8InspectorClient__BASE__consoleAPIMessage
  15:        0x178529b08 - _v8_inspector__V8InspectorClient__BASE__consoleAPIMessage
  16:        0x17846bc80 - _rustsecp256k1_v0_8_1_default_error_callback_fn
  17:        0x19c227fa8 - __pthread_joiner_wake

This is the error both locally on an M1 mac and on CI on linux-64
@jonmmease jonmmease added the bug Something isn't working label Jun 30, 2023
@jonmmease
Copy link
Collaborator Author

Reported in denoland/deno#19670

This was referenced Jul 4, 2023
Merged
Merged
jonmmease added a commit that referenced this issue Jul 6, 2023
@jonmmease
Add failing test case for crash in #78
d95e959
@jonmmease jonmmease mentioned this issue Jul 6, 2023
Merged
jonmmease added a commit that referenced this issue Jul 7, 2023
@jonmmease
Use current thread tokio runtime to fix deno crash (#82)
07565bd 
* Add failing test case, lookup_urls, for crash in #78

* Use current_thread runtime to fix crash

* lift TOKIO_RUNTIME.block_on

* Use multi-threaded tokio runtime in Python
@jonmmease jonmmease mentioned this issue Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use current thread tokio runtime to fix deno crash vega/vl-convert
1 participant
@jonmmease